UHF multi detector: implement fast poll of multiple UHFs#721
Open
ysalatheZI wants to merge 2 commits intodevelopfrom
Open
UHF multi detector: implement fast poll of multiple UHFs#721ysalatheZI wants to merge 2 commits intodevelopfrom
ysalatheZI wants to merge 2 commits intodevelopfrom
Conversation
ysalatheZI
force-pushed
the
yvess/uhf_multi_detector_fast_poll
branch
2 times, most recently
from
fc6c69a to
1806359
Compare
ysalatheZI
changed the title
ysalatheZI
force-pushed
the
yvess/uhf_multi_detector_fast_poll
branch
from
9cec522 to
efd1b63
Compare
ysalatheZI
changed the title
Contributor
Author
|
This pull request is ready for review. |
Member
|
@RuggeroDiCarlo and @leodicarlo, what is the status of these changes? |
Member
|
After talking with @RuggeroDiCarlo I understand that there are two (identical) instances of this code. Naturally I rather not push changes this way since it is very sensitive to errors and merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please use the following template for a pull request.
Loop over detectors in the inner-most poll loop in the UHF multi detector.
@leodicarlo , @mariosk-zi
In order for the pull request to be merged, the following conditions must be met:
Whenever possible the pull request should
Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.